Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badgerdb and ristretto v0.2.0 to fix bugs on arm #98

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

atlas-comstock
Copy link
Collaborator

No description provided.

@kelindar
Copy link
Collaborator

kelindar commented Jun 7, 2022

Looks god, should we merge it @atlas-comstock ?

@atlas-comstock
Copy link
Collaborator Author

@kelindar plz wait, I 'll validate it today and tmr. thanks

@atlas-comstock
Copy link
Collaborator Author

We are using talaria -> badgerDB -> ristretto cache(dep relationship) and as the mmap issue happened on ristretto, we have to fork badgerDB and ristretto.

After forking, to make sure the dependency works well, we use go module replace like this:
replace github.com/dgraph-io/badger/v3 v3.2103.1 => github.com/atlas-comstock/badger/v3 v3.2103.1-with-arm-fix

At last, I found that the ristretto still use the original version even though I had replaced it in my github.com/atlas-comstock/badger/v3 v3.2103.1-with-arm-fix version.
Therefore, I have to replace them both on talaria:

replace github.com/dgraph-io/badger/v3 v3.2103.1 => github.com/atlas-comstock/badger/v3 v3.2103.1-with-arm-fix

replace github.com/dgraph-io/ristretto v0.1.0 => github.com/atlas-comstock/ristretto v0.2.0

@kelindar kelindar marked this pull request as ready for review June 16, 2022 06:04
@kelindar kelindar merged commit d1e86c9 into talariadb:master Jun 16, 2022
@atlas-comstock
Copy link
Collaborator Author

Fix #92 #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants